Skip to content

Commit

Permalink
modify(#143): 사용되지 않는 constructor 삭제
Browse files Browse the repository at this point in the history
  • Loading branch information
hobiJeong committed Nov 22, 2023
1 parent 843e49d commit 005d6d4
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 42 deletions.
8 changes: 3 additions & 5 deletions src/boards/controllers/Boards.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ import { ApiDeleteBoard } from '../swagger-decorators/delete-board-decorators';
import { ApiUpdateBoardImage } from '../swagger-decorators/patch-board-images-decorators';
import { JwtAccessTokenGuard } from 'src/config/guards/jwt-access-token.guard';
import { GetUserId } from 'src/common/decorators/get-userId.decorator';
import { BoardOwnerGuard } from 'src/config/guards/board-owner.guard';
import { BoardOwner } from 'src/common/decorators/board-owner.decorator';
import { JwtOptionalGuard } from 'src/config/guards/jwt-optional.guard';

@Controller('boards')
@ApiTags('board API')
Expand Down Expand Up @@ -74,14 +73,13 @@ export class BoardsController {
}

@Get('/unit')
@UseGuards(BoardOwnerGuard)
@UseGuards(JwtOptionalGuard)
@ApiGetOneBoard()
async findOne(
@Query('boardId') boardId: number,
@BoardOwner() unitOnwer: boolean,
@GetUserId() userId: number,
): Promise<BoardResponseDTO> {
return await this.boardsService.findOneBoard(boardId, userId, unitOnwer);
return await this.boardsService.findOneBoard(boardId, userId);
}

@Patch('')
Expand Down
9 changes: 4 additions & 5 deletions src/boards/controllers/boards-like.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,24 @@ import {
ValidationPipe,
Query,
UseGuards,
UseInterceptors,
} from '@nestjs/common';
import { BoardsLikeService } from '../services/boards-like.service';
import { ApiTags } from '@nestjs/swagger';
import { ApiAddBoardLike } from '../swagger-decorators/add-board-like.decorator';
import { ApiGetBoardLikeCount } from '../swagger-decorators/get-board-like-count.decorator';
import { ApiDeleteBoardLike } from '../swagger-decorators/delete-board-like.decorator';
import { TokenService } from 'src/auth/services/token.service';
import { GetUserId } from 'src/common/decorators/get-userId.decorator';
import { JwtAccessTokenGuard } from 'src/config/guards/jwt-access-token.guard';
import { JwtOptionalGuard } from 'src/config/guards/jwt-optional.guard';
import { SuccessResponseInterceptor } from 'src/common/interceptors/success-response.interceptor';

@ApiTags('BOARDS-LIKE')
@UsePipes(ValidationPipe)
@UseInterceptors(SuccessResponseInterceptor)
@Controller('boards')
export class BoardsLikeController {
constructor(
private tokenService: TokenService,
private boardsLikeService: BoardsLikeService,
) {}
constructor(private boardsLikeService: BoardsLikeService) {}

@ApiAddBoardLike()
@Post('like/:boardId')
Expand Down
3 changes: 1 addition & 2 deletions src/boards/services/Boards.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,9 @@ export class BoardsService {
async findOneBoard(
boardId: number,
userId: number,
unitOnwer: boolean,
): Promise<oneBoardResponseDTO> {
const board = await this.boardRepository.findBoardById(boardId);
const unitowner = unitOnwer;
const unitowner = board.userId === userId;
if (!board) {
throw new Error('게시물을 찾을 수 없습니다.');
}
Expand Down
3 changes: 2 additions & 1 deletion src/comments/controllers/comments.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { ApiAddReComment } from '../swagger-decoratros/add-recomment-decorators'
import { ApiUpdateReComment } from '../swagger-decoratros/patch-recomment-decorator';
import { JwtAccessTokenGuard } from 'src/config/guards/jwt-access-token.guard';
import { GetUserId } from 'src/common/decorators/get-userId.decorator';
import { JwtOptionalGuard } from 'src/config/guards/jwt-optional.guard';

@Controller('comments')
@ApiTags('Comment API')
Expand Down Expand Up @@ -60,7 +61,7 @@ export class CommentsController {
}

@Get('')
@UseGuards(JwtAccessTokenGuard)
@UseGuards(JwtOptionalGuard)
@ApiGetAllComment()
async getComment(
@GetUserId() userId: number,
Expand Down
29 changes: 0 additions & 29 deletions src/config/guards/board-owner.guard.ts

This file was deleted.

0 comments on commit 005d6d4

Please sign in to comment.