🔨 Refactor(#100): SortDropdown top 속성 제거 후 height 같은 값으로 대체

modern-agile-team · Jan 15, 2025 · 5323b24 · 5323b24
1 parent 319a76b
commit 5323b24
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/src/common/layout/SortDropdown.tsx b/src/common/layout/SortDropdown.tsx
@@ -15,7 +15,6 @@ interface SortDropDownProps<T extends Record<PropertyKey, any>> {
   width?: string; // 너비
   height?: string; // 높이
   fontSize?: string; // 글자 사이즈
-  top?: string; // li, ul 사이 거리
   ulFontColor?: string; // ul 폰트 색
   liFontColor?: string; // li 폰트 색
   ulBackgroundColor?: string; // ul 배경 색
@@ -57,7 +56,6 @@ export default function SortDropdown<T extends Record<PropertyKey, any>>({
   width,
   height,
   fontSize,
-  top,
   ulFontColor,
   liFontColor,
   ulBackgroundColor,
@@ -90,7 +88,7 @@ export default function SortDropdown<T extends Record<PropertyKey, any>>({
       {isOpen && (
         <S.SortOptionUl
           $width={width}
-          $top={top}
+          $height={height}
           $backgroundColor={ulBackgroundColor}
           $fontColor={ulFontColor}
           $borderColor={borderColor}

diff --git a/src/common/layout/styles.ts b/src/common/layout/styles.ts
@@ -77,14 +77,14 @@ export const SortSelectButton = styled.button<{
 `;
 
 export const SortOptionUl = styled.ul<{
-  $top?: string;
   $width?: string;
+  $height?: string;
   $backgroundColor?: string;
   $fontColor?: string;
   $borderColor?: string;
 }>`
   position: absolute;
-  top: ${({ $top }) => $top};
+  top: ${({ $height }) => $height};
   width: ${({ $width }) => $width};
   border-radius: 0 0 15px 15px;
   background-color: ${({ $backgroundColor }) => $backgroundColor};

diff --git a/src/features/ranking/ui/RankingContainer.tsx b/src/features/ranking/ui/RankingContainer.tsx
@@ -34,7 +34,6 @@ export default function RankingContainer({
           width="136px"
           height="30px"
           fontSize="12px"
-          top="30px"
           ulFontColor="#FFF3C0"
           liFontColor="#D37744"
           ulBackgroundColor="#d37744"