Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InView 컴포넌트 polymorphicForwardRef 적용 #607

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

ssi02014
Copy link
Contributor

@ssi02014 ssi02014 commented Nov 26, 2024

Overview

fix: InView 컴포넌트 polymorphicForwardRef 적용

PR Checklist

  • All tests pass.
  • All type checks pass.
  • I have read the Contributing Guide document.
    Contributing Guide

Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: bc49a19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ssi02014 ssi02014 self-assigned this Nov 26, 2024
@ssi02014 ssi02014 added @modern-kit/react @modern-kit/react fix 버그 수정 및 코드 개선 labels Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.10%. Comparing base (33cf068) to head (bc49a19).
Report is 97 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   97.41%   97.10%   -0.32%     
==========================================
  Files         164      178      +14     
  Lines        1470     1623     +153     
  Branches      361      399      +38     
==========================================
+ Hits         1432     1576     +144     
- Misses         34       42       +8     
- Partials        4        5       +1     
Components Coverage Δ
@modern-kit/react 95.06% <ø> (-0.15%) ⬇️
@modern-kit/utils 99.58% <ø> (-0.42%) ⬇️

@ssi02014 ssi02014 force-pushed the fix/inView branch 3 times, most recently from aade6bf to cd0e7c5 Compare November 26, 2024 06:28
@ssi02014 ssi02014 force-pushed the fix/inView branch 3 times, most recently from 0d308ef to 22fb44a Compare November 26, 2024 08:07
@ssi02014 ssi02014 changed the title fix: InView 컴포넌트 개선 docs: InView 컴포넌트 문서 수정 Nov 26, 2024
@ssi02014 ssi02014 added documentation 문서 추가 및 수정 and removed fix 버그 수정 및 코드 개선 labels Nov 26, 2024
@ssi02014 ssi02014 changed the title docs: InView 컴포넌트 문서 수정 fix: InView 컴포넌트 polymorphicForwardRef 적용 Nov 26, 2024
@ssi02014 ssi02014 merged commit 35de803 into main Nov 26, 2024
2 checks passed
@ssi02014 ssi02014 deleted the fix/inView branch November 26, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 문서 추가 및 수정 @modern-kit/react @modern-kit/react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant