Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formatNumberWithCommas 로직 수정으로 인터페이스 개선 #663

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ssi02014
Copy link
Contributor

@ssi02014 ssi02014 commented Jan 8, 2025

Overview

fix: formatNumberWithCommas 로직 수정으로 인터페이스 개선

PR Checklist

  • All tests pass.
  • All type checks pass.
  • I have read the Contributing Guide document.
    Contributing Guide

@ssi02014 ssi02014 added @modern-kit/utils @modern-kit/utils fix 버그 수정 및 코드 개선 labels Jan 8, 2025
@ssi02014 ssi02014 self-assigned this Jan 8, 2025
Copy link

changeset-bot bot commented Jan 8, 2025

⚠️ No Changeset found

Latest commit: 0e0a1d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (33cf068) to head (0e0a1d7).
Report is 144 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
+ Coverage   97.41%   98.21%   +0.80%     
==========================================
  Files         164      180      +16     
  Lines        1470     1628     +158     
  Branches      361      433      +72     
==========================================
+ Hits         1432     1599     +167     
+ Misses         34       27       -7     
+ Partials        4        2       -2     
Components Coverage Δ
@modern-kit/react 96.95% <ø> (+1.73%) ⬆️
@modern-kit/utils 99.50% <ø> (-0.50%) ⬇️

@ssi02014 ssi02014 merged commit 12ec7aa into main Jan 8, 2025
3 checks passed
@ssi02014 ssi02014 deleted the feat/format branch January 8, 2025 05:22
@ssi02014 ssi02014 restored the feat/format branch January 8, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 버그 수정 및 코드 개선 @modern-kit/utils @modern-kit/utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant