[stdlib] Add iterator for LinkedList #4005
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgreni
force-pushed
the
linked_list_iter
branch
2 times, most recently
from
4e8ec25 to
517393a
Compare
owenhilyard
reviewed
Feb 18, 2025
|
Other than some doc clarifications, looks good to me. |
JoeLoser
approved these changes
Feb 18, 2025
bgreni
force-pushed
the
linked_list_iter
branch
from
517393a to
e061f8e
Compare
Signed-off-by: Brian Grenier <[email protected]>
bgreni
force-pushed
the
linked_list_iter
branch
from
e061f8e to
7eb9b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some previous discussion about whether casting the lifetime of the list elements in this manner was sound, but now that 25.1 is out the door I think we can revisit this?
From my understanding the lifetime of the list elements should be the same as the list itself so it should be fine to do it this way?