[stdlib] Refactor atol: StringRef to StringSlice and reusability
#3207
Conversation
jjvraw
changed the title
atol for reusability
jjvraw
force-pushed
the
refact/atol
branch
3 times, most recently
from
5b8b424
to
05740d2
Compare
jjvraw
changed the title
atol: StringRef to StringSlice and reusability
So sorry this one fell off my radar and I'm just seeing this again now. I'm still +1 for the change. Do you mind rebasing? I know @martinvuyk has been working a lot in this area recently, so things may have changed quite a bit as we've been moving off of |
There was a problem hiding this comment.
I haven't touched anything around atof and atol since I knew other people were working on it. Viewing the git blame it seems like this hasn't been touched since more than 6 months ago, so I think this will have trivial conflicts. @jjvraw Thanks again for working on this :)
stdlib/src/collections/string.mojo
Outdated
| else: | ||
| start = pos | ||
| break | ||
| var str_len = len(str_slice) |
There was a problem hiding this comment.
| var str_len = len(str_slice) | |
| var str_len = str_slice.byte_length() |
stdlib/src/collections/string.mojo
Outdated
| fn _identify_base(str_ref: StringRef, start: Int) -> Tuple[Int, Int]: | ||
| var length = len(str_ref) | ||
| fn _identify_base(str_slice: StringSlice, start: Int) -> Tuple[Int, Int]: | ||
| var length = len(str_slice) |
There was a problem hiding this comment.
| var length = len(str_slice) | |
| var length = str_slice.byte_length() |
- StringRef to StringSlice - Introduce _handle_base_prefix & _trim_and_handle_sign - Changed var to alias Signed-off-by: Joshua James Venter <[email protected]>
Signed-off-by: Joshua James Venter <[email protected]>
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
|
Landed in be09f29! Thank you for your contribution 🎉 |
… reusability (#51354) [External] [stdlib] Refactor `atol`: `StringRef` to `StringSlice` and reusability This pull request modularises previously inline code, assisting in addressing issue #2639 to allow `stol` function to reuse some of the functionality. These changes, initially part of #3178, have been separated for easier review. The refactoring extracts `_handle_base_prefix` & `_trim_and_handle_sign`. Additionally, the docstring has been revised for clarity. Alongside these changes, the respective function signatures have been updated to move away from `StringRef` to `StringSlice`. There was also a small `FIXME` to convert from `var` to `alias`, which is now seems possible. Co-authored-by: Joshua James Venter <[email protected]> Closes #3207 MODULAR_ORIG_COMMIT_REV_ID: e733ed473f086abe6fc5acccae711e0114c1093d
This pull request modularises previously inline code, assisting in addressing issue #2639 to allow
stolfunction to reuse some of the functionality. These changes, initially part of PR #3178, have been separated for easier review.The refactoring extracts
_handle_base_prefix&_trim_and_handle_sign. Additionally, the docstring has been revised for clarity.Alongside these changes, the respective function signatures have been updated to move away from
StringReftoStringSlice.There was also a small
FIXMEto convert fromvartoalias, which is now seems possible.