-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Rename py_object
to py_object_ptr
#3605
base: nightly
Are you sure you want to change the base?
Conversation
Also, might be beneficial to rename |
@ConnorGray curious to get your thoughts and eyes here. |
+1 to this, that function isn't used widely so happy to see that small cleanup here as well :) |
I'll defer to @ConnorGray on the final call here, but I'll sync this in regardless. Thanks! |
!sync |
Signed-off-by: Joshua James Venter <[email protected]>
Ola :) Gentle reminder @ConnorGray, if this is still wanted. Apologies for the delayed rebase. End of uni semester had my attention. |
Apologies if this needs discussion. However, while working in these files, It seems odd to have an attribute of
PythonObject
namedpython_object
that stores aPyObjectPtr
.This will cause conflicts with