Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Fix unsafe String.write_bytes() #3773

Closed
wants to merge 4 commits into from
Closed

[stdlib] Fix unsafe String.write_bytes() #3773

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb13d54
Fix unsafe String.write_bytes()
martinvuyk Nov 15, 2024
c1c5516
add debug_assert for null termination
martinvuyk Nov 15, 2024
a262550
fix bounds check
martinvuyk Nov 15, 2024
8dd4acd
revert debug assert
martinvuyk Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions stdlib/src/collections/string.mojo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,14 +847,13 @@ struct String(
# ===------------------------------------------------------------------=== #

fn write_bytes(inout self, bytes: Span[Byte, _]):
"""
Write a byte span to this String.
"""Write a byte span to this String.

Args:
bytes: The byte span to write to this String. Must NOT be
null terminated.
null terminated.
"""
self._iadd[True](bytes)
self._iadd[False](bytes)

fn write[*Ts: Writable](inout self, *args: *Ts):
"""Write a sequence of Writable arguments to the provided Writer.
Expand Down