Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] [NFC] Rename SIMD.type to SIMD.D #3812

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from
Open

[stdlib] [NFC] Rename SIMD.type to SIMD.D #3812

wants to merge 1 commit into from

Conversation

martinvuyk
Copy link
Contributor

Rename SIMD.type to SIMD.D. Part of #3811

@martinvuyk
Rename SIMD.type to SIMD.D
f929aa3 
Signed-off-by: martinvuyk <[email protected]>
@martinvuyk martinvuyk requested a review from a team as a code owner November 26, 2024 00:20
@gryznar
Copy link
Contributor

gryznar commented Nov 26, 2024 •
edited
Loading

-1. This look strange and is inconsistent with size param.

@martinvuyk
Copy link
Contributor Author

martinvuyk commented Nov 26, 2024 •
edited
Loading

size is a variable
D is a Type
I don't see your point

(if you still want to do SIMD.type it will work fine since it's an alias for D inside the struct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinvuyk @gryznar