-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove flash based xtypes #15312
Remove flash based xtypes #15312
Conversation
This PR could be backported/copied to 2.x |
What if an extra relies on these? |
Then the extras have a different issue, because browser based flash is EOL. Maybe we could add the removed parts to an extra file. |
Maybe in the future it makes sense to transfer/remove other components that are not used? |
http://swfobject.googlecode.com/svn/trunk/swfobject/expressInstall.swf and http://yui.yahooapis.com/2.8.2/build/charts/assets/charts.swf don't exist anymore. So the Ext.chart things could be removed. They can't be used anymore and should currently throw an error. |
The FileApi code has a fallback to flash, but the referenced files are not available anymore. It could be disabled quite easy. |
'chart', 'piechart', 'cartesianchart' and the derived xtypes
A github search for MODx.util.Clipboard filename:utilities.js shows 459 results, most in the utilities.js file or in some cache files. So I think that the component is no longer in use.
What does it do?
Remove flash based xtypes
Why is it needed?
It could be possible, that sites running any Flash will be actively blocked by Chrome.
How to test
The manager works with this changes and the xtypes removed are not used in the core.
Related issue(s)/PR(s)
#13199 (comment)