Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flash based xtypes #15312

Merged
merged 7 commits into from
Feb 9, 2021
Merged

Remove flash based xtypes #15312

merged 7 commits into from
Feb 9, 2021

Conversation

Jako
Copy link
Collaborator

@Jako Jako commented Oct 28, 2020

What does it do?

Remove flash based xtypes

Why is it needed?

It could be possible, that sites running any Flash will be actively blocked by Chrome.

How to test

The manager works with this changes and the xtypes removed are not used in the core.

Related issue(s)/PR(s)

#13199 (comment)

@Jako Jako requested review from Mark-H and opengeek as code owners October 28, 2020 15:49
@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Oct 28, 2020
@Jako
Copy link
Collaborator Author

Jako commented Oct 28, 2020

This PR could be backported/copied to 2.x

@JoshuaLuckers
Copy link
Contributor

What if an extra relies on these?

@Jako
Copy link
Collaborator Author

Jako commented Oct 28, 2020

Then the extras have a different issue, because browser based flash is EOL.

Maybe we could add the removed parts to an extra file.

@Ruslan-Aleev
Copy link
Collaborator

Maybe in the future it makes sense to transfer/remove other components that are not used?
If there are many of them, then by removing them we will lighten the size of the distribution, we can avoid potential errors in the future (with flash, for example) and even update extJS components separately.

@Jako
Copy link
Collaborator Author

Jako commented Oct 28, 2020

http://swfobject.googlecode.com/svn/trunk/swfobject/expressInstall.swf and http://yui.yahooapis.com/2.8.2/build/charts/assets/charts.swf don't exist anymore. So the Ext.chart things could be removed. They can't be used anymore and should currently throw an error.

@Jako
Copy link
Collaborator Author

Jako commented Oct 28, 2020

The FileApi code has a fallback to flash, but the referenced files are not available anymore. It could be disabled quite easy.

@matdave matdave requested a review from JoshuaLuckers January 27, 2021 23:30
@JoshuaLuckers JoshuaLuckers added the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label Feb 6, 2021
@Ibochkarev Ibochkarev added this to the v3.0.0-alpha3 milestone Feb 7, 2021
Jako and others added 7 commits February 9, 2021 09:29
'chart', 'piechart', 'cartesianchart' and the derived xtypes
A github search for MODx.util.Clipboard filename:utilities.js shows 459 results, most in the utilities.js file or in some cache files. So I think that the component is no longer in use.
@opengeek opengeek merged commit 5fb05be into modxcms:3.x Feb 9, 2021
@Jako Jako deleted the remove-flash branch February 14, 2021 12:17
@Ibochkarev Ibochkarev removed the pr/ready-for-merging Pull request reviewed and tested and ready for merging. label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants