[3.x] Form Customization: Grid editing erases set data

.editorconfig

@@ -1,26 +1,18 @@
+# https://editorconfig.org
 root = true
 
 [*]
+charset = utf-8
 end_of_line = lf
 insert_final_newline = true
 trim_trailing_whitespace = true
 indent_style = space
-tab_width = 4
+indent_size = 4
+max_line_length = off
 
-[**.js]
-tab_width = 4
+[**.scss]
+indent_size = 2
 
-[**.coffee]
-tab_width = 4
-
-[**.cson]
-tab_width = 4
-
-[**.json]
-tab_width = 4
-
-[**rc]
-tab_width = 4
-
-[**php]
-tab_width = 4
+[*.md]
+max_line_length = off
+trim_trailing_whitespace = false

.github/CONTRIBUTING.md

@@ -11,7 +11,7 @@ Only English lexicon changes are handled in GitHub. If you want to update anythi
 ### Other
  * Did you find an issue in xPDO? Please submit it in [xPDO repository](https://github.com/modxcms/xpdo).
  * Did you find an issue in a MODX Extra? Please submit it to that component's repository or contact the author.
- * Looking for advise or help? Please search the [MODX documentation](http://rtfm.modx.com/), the [MODX forums](http://forums.modx.com/) or join to #modx or #xpdo room on IRC FreeNode server (irc.freenode.net).
+ * Looking for advice or help? Please search the [MODX documentation](https://docs.modx.com/), the [MODX Community](https://community.modx.com/), join to #modx or #xpdo room on IRC FreeNode server (irc.freenode.net) or join the [MODX Community on Slack](https://modx.org/).
 
 ## Submit a bug report
 
@@ -55,7 +55,7 @@ Only English lexicon changes are handled in GitHub. If you want to update anythi
     Let us know if this is related to any issue/pull request.
 
 ## Submit a Pull Request
-If this is your first PR, please create an account on the [MODX website](http://www.modx.com) and sign the [Contributors License Agreement](http://develop.modx.com/contribute/cla/). This is needed to ensure all code is licensed properly. We cannot merge pull requests without a signed CLA.
+If this is your first PR, please create an account on the [MODX website](http://www.modx.com) and sign the [Contributors License Agreement](https://modx.com/community/cla/). This is needed to ensure all code is licensed properly. We cannot merge pull requests without a signed CLA.
 
 MODX supports PHP from v5.3, so your PRs have to work on PHP 5.3+. **PRs must be backwards compatible.**
 

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,7 +1,7 @@
 ---
 name: Bug report
 about: Create a report to help us improve MODX Revolution
-
+labels: bug
 ---
 
 ## Bug report
@@ -18,4 +18,4 @@ How it behaved after following steps above.
 How it should behave after following steps above.
 
 ### Environment
-MODX version, apache/nginx and version, mysql version, browser, etc. Any relevant information.
+MODX version, apache/nginx and version, mysql version, browser, etc. Any relevant information.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,7 +1,7 @@
 ---
 name: Feature request
 about: Suggest an idea that makes MODX Revolution even better
-
+labels: feature
 ---
 
 ## Feature request
@@ -15,4 +15,4 @@ A clear and concise description of what the problem is. Ex. I'm always frustrate
 A clear and concise description of what you want to happen.
 
 ### Related issue(s)/PR(s)
-Let us know if this is related to any issue/pull request.
+Let us know if this is related to any issue/pull request.

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,8 +1,11 @@
 ### What does it do?
-Describe the technical changes you did.
+Describe the technical changes you made.
 
 ### Why is it needed?
 Describe the issue you are solving.
 
+### How to test
+Describe how to test the changes you made.
+
 ### Related issue(s)/PR(s)
-Let us know if this is related to any issue/pull request (see https://github.com/blog/1506-closing-issues-via-pull-requests)
+Provide any issue that's addressed by this change in the format "Resolves #<issue number>", and mention other issues/pull requests with relevant information. 

.github/dependabot.yml

@@ -0,0 +1,8 @@
+version: 2
+updates:
+
+  # Maintain dependencies for Composer
+  - package-ecosystem: "composer"
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/workflows/assets.yml

@@ -0,0 +1,31 @@
+name: "Compile Assets"
+
+on:
+    push:
+        paths:
+            - "_build/templates/**"
+    pull_request:
+        paths:
+            - "_build/templates/**"
+
+    workflow_dispatch:
+
+jobs:
+    compile-assets:
+        runs-on: ubuntu-latest
+        steps:
+            -   name: Checkout
+                uses: actions/checkout@v2
+
+            -   name: Install Node.js
+                uses: actions/setup-node@v2
+                with:
+                    node-version: '14'
+                    cache: 'npm'
+                    cache-dependency-path: _build/templates/default/package-lock.json
+
+            -   name: Install NPM dependencies
+                run: cd _build/templates/default && npm install
+
+            -   name: Build assets
+                run: cd _build/templates/default && npm run build

.github/workflows/ci.yml

@@ -0,0 +1,66 @@
+name: CI
+
+on:
+  push:
+      branches-ignore:
+          - 'l10n_**'
+      paths-ignore:
+          - "_build/templates/**"
+  pull_request:
+      branches-ignore:
+          - 'l10n_**'
+      paths-ignore:
+          - "_build/templates/**"
+
+          # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
+
+jobs:
+  mysql-check:
+    name: MySQL Check
+    runs-on: ubuntu-20.04
+
+    services:
+      mysql:
+        image: "mysql:5.6"
+
+        options: >-
+          --health-cmd "mysqladmin ping --silent"
+          -e MYSQL_ALLOW_EMPTY_PASSWORD=yes
+          -e MYSQL_DATABASE=revo_test
+        ports:
+          - 3306:3306
+
+    strategy:
+      matrix:
+        php-version: ['7.2', '7.3', '7.4', '8.0']
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Install PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php-version }}
+          extensions: pdo, pdo_mysql, zip, mysqli, gd
+
+      - name: Get composer cache directory
+        id: composer-cache
+        run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+
+      - name: Cache composer dependencies
+        uses: actions/cache@v2
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: ${{ runner.os }}-composer-
+
+      - name: Install dependencies
+        run: composer install --no-progress --prefer-dist --optimize-autoloader
+
+      - name: Setup MODX
+        run: cd _build/test && ./generateConfigs.sh auto
+
+      - name: Run PHPUnit
+        run: core/vendor/bin/phpunit  --enforce-time-limit -c ./_build/test/phpunit.xml

.github/workflows/phpcs.yml

@@ -0,0 +1,28 @@
+name: "Code Quality"
+
+on:
+    pull_request:
+        paths:
+            - "**.php"
+            - "phpcs.xml"
+            - ".github/workflows/phpcs.yml"
+
+jobs:
+    phpcs:
+        runs-on: ubuntu-latest
+        steps:
+            - uses: actions/checkout@v2
+              with:
+                  fetch-depth: 0
+
+            - name: Install PHP_CodeSniffer
+              run: |
+                  curl -OL https://squizlabs.github.io/PHP_CodeSniffer/phpcs.phar
+                  php phpcs.phar --version --config-set ignore_warnings_on_exit 1
+
+            - uses: thenabeel/action-phpcs@v8
+              with:
+                  files: "**.php"
+                  phpcs_path: php phpcs.phar
+                  standard: phpcs.xml
+                  fail_on_warnings: false

.gitignore

@@ -48,7 +48,11 @@ _build/templates/default/sass/font-awesome
 
 # ignore composer files
 composer.phar
+#composer.json
 composer.lock
 
 # ignore composer vendor dir
 /vendor
+
+# ignore phpunit cache files
+.phpunit.result.cache

CODE_OF_CONDUCT.md

@@ -0,0 +1,50 @@
+# Contributor Covenant Code of Conduct
+
+The MODX Community, Leadership and Advisory Board has decided to use the [Contributor Covenant][homepage] until such time we ratify our own.
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at [email protected]. All complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at http://contributor-covenant.org/version/1/4
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see the FAQ at https://www.contributor-covenant.org/faq.
+Translations are available at https://www.contributor-covenant.org/translations.