Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bounding box covering the transparency "graphics state" should now match the bounding box of the SVG element it is applied to. We also need to add the width of the stroke, since this isn't normally covered by the bounding box.
I was trying to be conservative previously by using
prawn.state.page.dimensions
to bound the whole page, but this doesn't always work. If the SVG has been scaled the page dimensions my only cover some of the coordinate space covered by the SVG.Hopefully this is now correct. Prawn is a little bit inconsistent with how it handles bounding boxes and margins compared to other transformations. I had to use
prawn.bounds.anchor
to get the bounding box offset. So hopefully I'm not missing any other subtleties.