Restrict the CommentAnalyzer.kt only to the "I'm on it" magic words (I…

…vy-Apps#2781)
mohammednawas8 · Oct 9, 2023 · 06ed817 · 06ed817
1 parent 063a608
commit 06ed817
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 18 deletions.
diff --git a/.idea/kotlinScripting.xml b/.idea/kotlinScripting.xml
diff --git a/automations/issue-assign/src/main/kotlin/ivy/automate/issue/CommentAnalyzer.kt b/automations/issue-assign/src/main/kotlin/ivy/automate/issue/CommentAnalyzer.kt
@@ -5,14 +5,7 @@ import ivy.automate.base.github.model.GitHubUser
 
 val TakeIssueIntentionPhrases = listOf(
     "im on it",
-    "want to contribute",
-    "work on this",
-    "contribute on this",
-    "assign to me",
-    "assign this issue to me",
-    "assign this to me",
-    "give it a try",
-    "i take this"
+    "i am on it",
 )
 
 sealed interface CommentIntention {

diff --git a/automations/issue-assign/src/test/kotlin/ivy/automate/issue/CommentAnalyzerTest.kt b/automations/issue-assign/src/test/kotlin/ivy/automate/issue/CommentAnalyzerTest.kt
@@ -33,37 +33,43 @@ class CommentAnalyzerTest : FreeSpec({
             row("I'm on it", CommentIntention.TakeIssue(user)),
             row("Im on it", CommentIntention.TakeIssue(user)),
             row("im on it", CommentIntention.TakeIssue(user)),
-            row("want to contribute", CommentIntention.TakeIssue(user)),
-            row("I'm new to GitHub, can I work on this?", CommentIntention.TakeIssue(user)),
+            row("I am on it", CommentIntention.TakeIssue(user)),
             row(
-                "I would like to work on this.",
+                "yeah i am on it, also i wanted to ask " +
+                        "what resources should i use learn android",
                 CommentIntention.TakeIssue(user)
             ),
+            row("want to contribute", CommentIntention.Unknown),
+            row("I'm new to GitHub, can I work on this?", CommentIntention.Unknown),
+            row(
+                "I would like to work on this.",
+                CommentIntention.Unknown
+            ),
             row(
                 "Hi,\nI would like to work on this issue",
-                CommentIntention.TakeIssue(user)
+                CommentIntention.Unknown
             ),
             row(
                 "I'm interested to contribute on this feature.",
-                CommentIntention.TakeIssue(user)
+                CommentIntention.Unknown
             ),
             row(
                 "Sure, let me give it a try. Will keep posted here.",
-                CommentIntention.TakeIssue(user)
+                CommentIntention.Unknown
             ),
             row(
                 "Hey @ILIYANGERMANOV , I want to work on this issue. Please assign it to me.\n",
-                CommentIntention.TakeIssue(user)
+                CommentIntention.Unknown
             ),
             row(
                 "Hi @ILIYANGERMANOV, Assign this issue to me." +
                         "I think i will require some help in it from your side, " +
                         "so please bear with me.\n",
-                CommentIntention.TakeIssue(user)
+                CommentIntention.Unknown
             ),
             row(
                 "Can I take this one?",
-                CommentIntention.TakeIssue(user)
+                CommentIntention.Unknown
             ),
         ) { (text, expectedIntention) ->
             // given