fixed the hardest issue ever??

flomo/config.py

@@ -11,51 +11,70 @@
 
 tag_colors = {"Work": "red", "Study": "blue", "Exercise": "green"}
 
+# TODO: Fix: if config file is improper, it overrides changes made by the user.
+
 
 class Config:
     def __init__(
         self, initializing: bool = False, get_default_session_data: bool = False
     ):
         self.path = helpers.get_path("config.json", in_data=True)
+        self.do_check = not initializing and not get_default_session_data
 
-        if (
-            not initializing
-            and not get_default_session_data
-            and not self._config_data_check()
-        ):
+        if self.do_check and self._get_missing_keys() != []:
             raise errors.NoConfigError()
 
     def _config_file_exists(self):
-        return os.path.exists(self.path) and self._config_data_check()
+        missing_keys = self._get_missing_keys()
+        return os.path.exists(self.path), missing_keys
+
+    def _get_missing_keys(self):
+        if not os.path.exists(self.path):
+            return ["default_session_data", "notification_priority", "tag_colors"]
 
-    def _config_data_check(self):
         with open(self.path, "r") as f:
             data = json.load(f)
+            missing_keys = []
+
+            if (
+                "default_session_data" not in data
+                or data["default_session_data"].keys() != default_session_data.keys()
+            ):
+                missing_keys.append("default_session_data")
 
-            return all(
-                key in data
-                for key in [
-                    "default_session_data",
-                    "notification_priority",
-                    "tag_colors",
-                ]
-            ) and data["notification_priority"].lower() in ["off", "normal", "high"]
+            if "notification_priority" not in data or data[
+                "notification_priority"
+            ].lower() not in ["off", "normal", "high"]:
+                missing_keys.append("notification_priority")
+
+            if "tag_colors" not in data:
+                missing_keys.append("tag_colors")
+
+            return missing_keys
 
     def create_config(self):
-        if self._config_file_exists():
+        file_exists, missing_keys = self._config_file_exists()
+        print(file_exists, missing_keys)
+        if file_exists and missing_keys == []:
             return
 
         with open(self.path, "w") as f:
-            data = {
-                "default_session_data": default_session_data,
-                "notification_priority": "normal",
-                "tag_colors": tag_colors,
-            }
+            data = {}
+            for missing_key in missing_keys:
+                if missing_key == "default_session_data":
+                    data[missing_key] = default_session_data
+                elif missing_key == "notification_priority":
+                    data[missing_key] = "normal"
+                elif missing_key == "tag_colors":
+                    data[missing_key] = tag_colors
+
+            # TODO: If one key is missing, the rest of the keys are not added to the config file
 
             json.dump(data, f, indent=4)
 
     def get_config(self, key: str):
-        if key == "default_session_data" and not self._config_file_exists():
+        # TODO: If default_session_data is invalid in config, even init command doesnt work
+        if key == "default_session_data" and not self._config_file_exists()[0]:
             return default_session_data
 
         try: