Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: Enable Admonition extension #1514

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

wagner-intevation
Copy link
Contributor

the Admonition extension is built in the markdown-parser: https://python-markdown.github.io/extensions/admonition/ This PR enables the extension and adds documentation to it, as well as tests

The rst admonitions don't handle titles, so the documentation can't contain examples for this feature.

@wagner-intevation
Copy link
Contributor Author

Same strange test failure as in #1513

@wagner-intevation wagner-intevation force-pushed the markdown-admonition branch 2 times, most recently from 44998be to 409851e Compare September 20, 2023 21:11
@wagner-intevation
Copy link
Contributor Author

rebased on master

@RogerHaase
Copy link
Member

Please resubmit after resolving conflicts caused by PR 1511.

Ignore comment regarding help-en on PR 1511. Need to fix #1519

Thanks for helping!

the Admonition extension is built in the markdown-parser: https://python-markdown.github.io/extensions/admonition/
This PR enables the extension and adds documentation to it, as well as
tests

The rst admonitions don't handle titles, so the documentation can't
contain examples for this feature.
@wagner-intevation
Copy link
Contributor Author

rebased and force-pushed

@RogerHaase RogerHaase merged commit 06ac8d5 into moinwiki:master Sep 24, 2023
4 checks passed
@wagner-intevation wagner-intevation deleted the markdown-admonition branch September 25, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants