Update the referenced js file version #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It looks good to me. I closed my PR since @dami-moj already added most of the features in this PR. I added how to install a live server which I missed.
There was a problem hiding this comment.
Great work! I have a few suggestions:
- Can you delete
entries_skipped.jsonplease? - Can you move the section about explaining
radar_config.jsonandblips.jsonto the core README because this section is more about managing the discussions. - Can you move the section about live server to the core README as well
- Have you tested the logic setting ring_change =2 ? Just wanted to make sure it works :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix includes:
radar.jsandradar.css, while we await GitHub release from the tech-radar repo