Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor - Remove redundant InputStreamReader #1120

Closed
wants to merge 2 commits into from
Closed

Refactor - Remove redundant InputStreamReader #1120

wants to merge 2 commits into from

Conversation

JackPGreen
Copy link
Contributor

Rather than converting Files.newInputStream to a BufferedReader via an intermediate InputStreamReader, Files.newBufferedReader can be used instead.

This currently works the same internally in the JRE.

@slawekjaranowski slawekjaranowski added this to the next-release milestone Jul 19, 2024
@JackPGreen
Copy link
Contributor Author

Integration tests fail, clearly not a like-for-like change.

@JackPGreen JackPGreen closed this Aug 11, 2024
@slawekjaranowski slawekjaranowski removed this from the next-release milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackPGreen @slachiewicz @slawekjaranowski