build tarball using ustar format for better compatibility #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tell tar to use the ustar format when building the release tarball. ustar is the baseline format that doesn't include extra headers that will cause warnings on any other tar version. Without it, the archive will often end up with headers like `LIBARCHIVE.xattr.com.apple.quarantine`, which will produce warnings when extracted with GNU tar.
christopherraa
approved these changes
May 19, 2024
There was a problem hiding this comment.
The change in itself looks fine in terms of syntax. I am a bit usure if switching to the older tar format is what we'd want seeing as GNU tar is moving to posix as default tar format. For reference:
Usually, GNU tar is configured to create archives in ‘gnu’ format, however, a future version will switch to ‘posix’.
Source: https://www.gnu.org/software/tar/manual/html_section/Formats.html
I'll leave this up to some of the other maintainers to decide on.
|
'ustar' is the common denominator that is supported by all systems. The 'posix' format is an extension of 'ustar', adding additional headers that you will never need for an archive like this, and can cause compatibility issues on some systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
build tarball using ustar format for better compatibility
Motivation
ustar is the baseline format that doesn't include extra headers that will cause warnings on any other tar version. Without it, the archive will often end up with headers like
LIBARCHIVE.xattr.com.apple.quarantine, which will produce warnings when extracted with GNU tar.