-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove and ignore auto-generated files #2
base: master
Are you sure you want to change the base?
Conversation
Source: https://raw.githubusercontent.com/github/gitignore/master/{C,Autotools}.gitignore Plus some others for this particular project.
It was auto-generated anyway.
Note: The reason I'm doing this is because I have a version 0.8.1 tarball available, and I want a cleaner repo before I submit a PR to add those changes (lots of updates to auto-generated files that muddy up the commit).
|
Running autogen.sh that you have added requires that you have autotools installed on your machine. Normally, distributed software contains a complete configure system so you can compile and install the software simply by going configure; make; sudo make install. |
You're right. It is common practice to include these files in a release tarball. That's different than removing the auto-generated files from source control. It's possible to generate those files and add them to a release tarball using GitHub Releases. However, it isn't common practice to keep generated files in source control. The reason for this is threefold:
Say I change one line in
(Imagine the same scenario as before: a single-line change to configure.ac) Say I run a different version of autotools than the one the last committer used, now the file is generated differently and my commit now has 1000 lines of changes I didn't make by hand. It's not so obvious now that I just intended to change the one line.
Say you're coordinating with a team running an ancient version of autotools, and they check in a change and run TL;DR A good rule of thumb is: If you didn't write it by hand, don't check it in to source control. |
I see your point, I will take a closer look at your pull request. Thanks! |
Get them back by running
./autogen.sh
on a system with GNU autotools installed.