Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Refactoring and test fixes #14

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Refactoring and test fixes #14

wants to merge 16 commits into from

Conversation

moooji
Copy link

@moooji moooji commented Sep 2, 2015

Changes:

  • Fixed issue that most of the tests would always pass incorrectly
  • Hardened various tests to check for correct property values
  • Removed deprecated save methods
  • Changed to deferred indexing of documents so that only documents will be indexed that have successfully been stored in the database. Furthermore, MongoDB performance is not any longer affected by indexing and no data loss will occur in MongoDB in case that the search index is unavailable
  • "underscore" has been replaced with "lodash" for better performance and stronger checks
  • renderMapping function has been refactored and simplified so that it is easier to comprehend and debug
  • Various bug fixes and stronger checks

Additions:

  • options can now be supplied to registerModel function, which makes it possible to pass elasticsearch "index settings" for index creation
  • Tests have been added and documentation has been updated

Breaking change:

  • "modelname" has been renamed to more standard "modelName"

moooji added 16 commits September 2, 2015 15:38
@moooji
- Refactor of renderMapping function so that it is easier to comprehe…
98bdda0 
…nd what / how is happening

- Switched from "underscore" to "lodash" package for stronger checks and better performance
@moooji
Merge pull request #1 from moooji/refactor-renderMapping
da953a2 
Refactoring of renderMapping function
@moooji
- Added "options" to registerModel so that it is now possible to supp…
b5595a9 
…ly elasticsearch "settings" for the index.
@moooji
Minor fix
b750866
@moooji
Merge pull request #2 from moooji/feature-indexSettings
c707a2d 
Feature - registerModel takes now options to supply elasticsearch "index settings"
@moooji
minor fix
12f5e7d
@moooji
Merge pull request #3 from moooji/feature-indexSettings
1d6970f 
Minor fix to make tests pass
@moooji
Added tests for "index settings" feature
99da8f5
@moooji
Updated documentation
b1ed64c
@moooji
Merge pull request #4 from moooji/feature-indexSettings
708ad36 
Added tests and updated documentation for "index settings"
@moooji
Fixed indentation to be inline with original repo
cee1b05
@moooji
Fixed formatting to be inline with original repo
ef23ed1
@moooji
Refactor of renderMapping function so that it is more comprehendable
2f26387
@moooji
Minor refactoring to make code more predictable
0f44e39
@moooji
Refactoring to make code more predictable / stable
d535edb
@moooji
Major refactoring:
23ab97e 
- Fixed issue that most of the tests would always pass incorrectly
- Hardened various tests to check for correct property values
- Removed deprecated save methods
- Changed to deferred indexing of documents so that only documents will be indexed that have successfully been stored in the database. Furthermore, MongoDB performance is not any longer affected by indexing and no data loss will occur in MongoDB case that the search index is unavailable
- Various bug fixes
@moooji moooji mentioned this pull request Sep 2, 2015
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@moooji