Add hook middlewares interceptors to preserve call context with call middlewares. #1270
+113
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
When using middleware for the call method, the call context was lost, as described in #1241 . This issue occurred because the context was passed through the mutation of the promise. Consequently, if the middleware awaited the result from the promise and returned a new promise, the execution context was lost.
In order to maintain backward compatibility, I propose the following solution:
We can wrap the middleware for specific hooks, such as call, in an interceptor function. The interceptor is responsible for setting the context value for the promise that will be returned from the user's middleware.
In this pull request, I have added interceptor functionality to the MiddlewareHandler class, as well as an interceptor method for the call hook in the ServiceBroker class.
🎯 Relevant issues
#1241
💎 Type of change
🚦 How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
🏁 Checklist: