-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dict streaming #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement key-based access: config['description'] * add __repr__ method
* avoid that AutoConfiguration calls the _get_config method of the Model class (instead let _get_config returns an AutoConfiguration) * make package and file-based configuration two exclusive options in AutoConfiguration
* add types * derive DefaultConfiguration from DictConfiguration * move yaml search code from AutoConfiguration to SearchYamlConfiguration * implement proper merge mechanism in MergedConfiguration * move code from AutoConfiguration to model classes
* introduce convenient Explorer._read method * add another criterion to find the best reader in DepthFirstExplorer * change type Generator[..., None, None] to Iterator[...] * make ReaderRegistry aware of potential constructor arguments in individual reader classes
* move file-based code from Writer to a new class FileWriter * implement new writer classes: IteratorWriter, PandasWriter, and RecordListWriter. * update the WriterRegistry to support registering and retrieving writers based on output format
* implement special case of filtering "H" in FilterByElement * remove pipeline classes (they are replaced by list of preprocessing steps) * remove pipeline registry since it is not needed anymore * move code to Step / MapStep classes
* move class_decorator in utils submodule * implement call_with_mappings that calls a method and assigns function arguments by name * implement method to retrieve the file of a given class instance
* move code for assigning mol ids and names to separate classes (AssignMolId, AssignName) * move code that takes care of adding missing columns to a separate class (EnforceSchema) * let the base class Model handle prediction of molecules * add all additional convenience code to SimpleModel (configuration, input, output) * implement wrapper classes for input reading (ReadInput) and output writing (WriteOutput)
* merge different model classes into one class * merge all scenario test cases into one file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.