Merge pull request #3 from mollie/feature/support-all-apis

Feature/support all apis
mollie · Dec 17, 2024 · 3a4e127 · 3a4e127
2 parents 3fc483a + c6af50a
commit 3a4e127
Show file tree

Hide file tree

Showing 18 changed files with 2,840 additions and 2,352 deletions.
diff --git a/apis/admin_test.go b/apis/admin_test.go
diff --git a/apis/artifacts.go b/apis/artifacts.go
@@ -21,14 +21,8 @@ func NewArtifactsAPI(client *client.Client) *ArtifactsAPI {
 	}
 }
 
-var (
-	ErrArtifactNotFound = errors.New("artifact not found")
-	ErrMethodNotAllowed = errors.New("method not allowed or disabled on the server")
-	ErrInvalidInput     = errors.New("input must be between 1 and 512 characters")
-)
-
 // GetArtifactByGlobalID Gets the content for an artifact version in the registry using its globally unique identifier.
-// See https://schema-registry.dev.mollielabs.net/apis/registry/v3#operation/getContentByGlobalId
+// See https://www.apicur.io/registry/docs/apicurio-registry/3.0.x/assets-attachments/registry-rest-api.htm#tag/Artifacts/operation/getContentByGlobalId
 func (api *ArtifactsAPI) GetArtifactByGlobalID(ctx context.Context, globalID int64, params *models.GetArtifactByGlobalIDParams) (*models.ArtifactContent, error) {
 	returnArtifactType := false
 	query := ""
@@ -69,8 +63,8 @@ func (api *ArtifactsAPI) GetArtifactByGlobalID(ctx context.Context, globalID int
 
 // SearchArtifacts - Search for artifacts using the given filter parameters.
 // Search for artifacts using the given filter parameters.
-// See https://schema-registry.dev.mollielabs.net/apis/registry/v3#operation/searchArtifacts
-func (api *ArtifactsAPI) SearchArtifacts(ctx context.Context, params *models.SearchArtifactsParams) (*[]models.SearchedArtifact, error) {
+// See https://www.apicur.io/registry/docs/apicurio-registry/3.0.x/assets-attachments/registry-rest-api.htm#tag/Artifacts/operation/searchArtifacts
+func (api *ArtifactsAPI) SearchArtifacts(ctx context.Context, params *models.SearchArtifactsParams) ([]models.SearchedArtifact, error) {
 	query := ""
 	if params != nil {
 		if err := params.Validate(); err != nil {
@@ -90,13 +84,13 @@ func (api *ArtifactsAPI) SearchArtifacts(ctx context.Context, params *models.Sea
 		return nil, err
 	}
 
-	return &result.Artifacts, nil
+	return result.Artifacts, nil
 }
 
 // SearchArtifactsByContent searches for artifacts that match the provided content.
 // Returns a paginated list of all artifacts with at least one version that matches the posted content.
 // See https://www.apicur.io/registry/docs/apicurio-registry/3.0.x/assets-attachments/registry-rest-api.htm#tag/Artifacts/operation/searchArtifactsByContent
-func (api *ArtifactsAPI) SearchArtifactsByContent(ctx context.Context, content []byte, params *models.SearchArtifactsByContentParams) (*[]models.SearchedArtifact, error) {
+func (api *ArtifactsAPI) SearchArtifactsByContent(ctx context.Context, content []byte, params *models.SearchArtifactsByContentParams) ([]models.SearchedArtifact, error) {
 	// Convert params to query string
 	query := ""
 	if params != nil {
@@ -117,7 +111,7 @@ func (api *ArtifactsAPI) SearchArtifactsByContent(ctx context.Context, content [
 		return nil, err
 	}
 
-	return &result.Artifacts, nil
+	return result.Artifacts, nil
 }
 
 // ListArtifactReferences Returns a list containing all the artifact references using the artifact content ID.
@@ -164,7 +158,7 @@ func (api *ArtifactsAPI) ListArtifactReferencesByGlobalID(ctx context.Context, g
 
 // ListArtifactReferencesByHash Returns a list containing all the artifact references using the artifact content hash.
 // See https://www.apicur.io/registry/docs/apicurio-registry/3.0.x/assets-attachments/registry-rest-api.htm#tag/Artifacts/operation/referencesByContentHash
-func (api *ArtifactsAPI) ListArtifactReferencesByHash(ctx context.Context, contentHash string) (*[]models.ArtifactReference, error) {
+func (api *ArtifactsAPI) ListArtifactReferencesByHash(ctx context.Context, contentHash string) ([]models.ArtifactReference, error) {
 	url := fmt.Sprintf("%s/ids/contentHashes/%s/references", api.Client.BaseURL, contentHash)
 	resp, err := api.executeRequest(ctx, http.MethodGet, url, nil)
 	if err != nil {
@@ -176,7 +170,7 @@ func (api *ArtifactsAPI) ListArtifactReferencesByHash(ctx context.Context, conte
 		return nil, err
 	}
 
-	return &references, nil
+	return references, nil
 }
 
 // ListArtifactsInGroup lists all artifacts in a specified group.
@@ -295,7 +289,7 @@ func (api *ArtifactsAPI) DeleteArtifact(ctx context.Context, groupID, artifactId
 	if err != nil {
 		return err
 	}
-	
+
 	return handleResponse(resp, http.StatusNoContent, nil)
 }
 
@@ -306,6 +300,10 @@ func (api *ArtifactsAPI) CreateArtifact(ctx context.Context, groupId string, art
 		return nil, err
 	}
 
+	if err := artifact.Validate(); err != nil {
+		return nil, errors.Wrap(err, "invalid artifact provided")
+	}
+
 	query := ""
 	if params != nil {
 		if err := params.Validate(); err != nil {