feat: add exponential backoff retry strategy #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new retry strategy that waits for a jittered, exponentially increasing time between attempts until the deadline passes.
nand4011
force-pushed
the
exponential-backoff-retry
branch
from
8c5f793 to
da5c62f
Compare
Add a deadline check to the RetryClientInterceptor so that it won't retry after the deadline has passed. If this isn't present, retries will still happen, but will immediately fail.
rishtigupta
reviewed
Feb 18, 2025
momento-sdk/src/main/java/momento/sdk/retry/ExponentialBackoffRetryStrategy.java
Show resolved
Hide resolved
rishtigupta
reviewed
Feb 18, 2025
momento-sdk/src/intTest/java/momento/sdk/retry/FixedDelayRetryStrategyIntegTest.java
Show resolved
Hide resolved
momento-sdk/src/intTest/java/momento/sdk/retry/FixedDelayRetryStrategyIntegTest.java
Show resolved
Hide resolved
Add docs to ExponentialBackoffRetryStrategy. Add new constructors to ExponentialBackoffRetryStrategy: one that uses defaults for initial delay and max backoff, and one that uses the default eligibility strategy. Make computePreviousBaseDelay return initial delay if currentBaseDelay is equal to the initial delay to prevent it from returning 0. Use the default eligibility strategy in the exponential backoff integration tests. Add a new integration test to show that ExponentialBackoffRetryStrategy will work if there is a temporary network outage. Rename the testNonRetryEligible temporary outage fixed delay test to testRetryEligible, because it is testing an eligible method.
nand4011
force-pushed
the
exponential-backoff-retry
branch
from
e9b98f6 to
2614086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new retry strategy that waits for a jittered, exponentially increasing time between attempts until the deadline passes.