chore: update protos #154
Merged
chore: update protos #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes generate_api_token temporarily, as it is currently not supported in the way this sdk has it.
malandis
reviewed
Oct 5, 2023
Comment on lines
+29
to
+42
| serde_json = "1.0" | ||
| thiserror = "1.0" | ||
| base64 = "0.21" | ||
| futures = "0" | ||
| zstd = "0.12.4" | ||
|
|
||
| [dev-dependencies] | ||
| base64-url = "1.4.13" | ||
| env_logger = "0.9.0" | ||
| tokio = { version = "1.26.0", features = ["full"] } | ||
| tokio-test = "0.4.2" | ||
| uuid = { version = "1.2.2", features = ["v4"] } | ||
| futures = "0.3.25" | ||
| anyhow = "1.0.68" | ||
| base64-url = "2" | ||
| env_logger = "0" | ||
| tokio = { version = "1", features = ["full"] } | ||
| tokio-test = "0" | ||
| uuid = { version = "1", features = ["v4"] } | ||
| futures = "0" | ||
| anyhow = "1" |
There was a problem hiding this comment.
Did you mean to remove the patch and minor versions across this? And should the application dependencies be pinned vs lower bounded with semver? eg log = "0.4" vs log = "^0.4"?
There was a problem hiding this comment.
For dev dependencies I don't think it matters. It's easier for the next person to cargo update if major versions aren't changing.
There was a problem hiding this comment.
OK. I'll open a ticket to unpin the application dependencies.
There was a problem hiding this comment.
Cool, thank you - that's worth considering!
malandis
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes generate_api_token temporarily, as it is currently not
supported in the way this sdk has it.