add list collection integration tests

momentohq · Nov 30, 2023 · 5a225ed · 5a225ed
1 parent cdd69c6
commit 5a225ed
Show file tree

Hide file tree

Showing 4 changed files with 1,442 additions and 3 deletions.
diff --git a/Sources/momento/CacheClient.swift b/Sources/momento/CacheClient.swift
@@ -451,6 +451,7 @@ public class CacheClient: CacheClientProtocol {
         do {
             try validateCacheName(cacheName: cacheName)
             try validateListName(listName: listName)
+            try validateTruncateSize(size: truncateFrontToSize)
             try validateTtl(ttl: ttl)
         } catch let err as SdkError {
             return CacheListPushBackError(error: err)
@@ -497,6 +498,7 @@ public class CacheClient: CacheClientProtocol {
         do {
             try validateCacheName(cacheName: cacheName)
             try validateListName(listName: listName)
+            try validateTruncateSize(size: truncateBackToSize)
             try validateTtl(ttl: ttl)
         } catch let err as SdkError {
             return CacheListPushFrontError(error: err)

diff --git a/Sources/momento/internal/utils/Validators.swift b/Sources/momento/internal/utils/Validators.swift
@@ -66,7 +66,7 @@ internal func validateListSliceStartEnd(startIndex: Int?, endIndex: Int?) throws
     if startIndex == nil || endIndex == nil {
         return
     }
-    if startIndex! > 0 || endIndex! < 0 {
+    if startIndex! > 0 && endIndex! < 0 {
         return
     }
     if endIndex! <= startIndex! {

diff --git a/Tests/momentoTests/cacheTests.swift b/Tests/momentoTests/cacheTests.swift
@@ -3,13 +3,11 @@ import XCTest
 
 final class cacheTests: XCTestCase {
     private var integrationTestCacheName: String!
-    private var topicClient: TopicClientProtocol!
     private var cacheClient: CacheClientProtocol!
 
     override func setUp() async throws {
         let testSetup = await setUpIntegrationTests()
         self.integrationTestCacheName = testSetup.cacheName
-        self.topicClient = testSetup.topicClient
         self.cacheClient = testSetup.cacheClient
     }