-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update php sdk version #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still a draft or is it ready for review
@@ -22,7 +22,7 @@ | |||
"source": "https://github.com/momentohq/laravel-cache" | |||
}, | |||
"require": { | |||
"momentohq/client-sdk-php": "1.3.0" | |||
"momentohq/client-sdk-php": "v1.7.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've been confused as to why these dep versions are switching between not having a v
prefix and having a v
prefix. do you know why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think git prefers using v for version number from now on: https://www.flownative.com/en/blog/semantic-versioning-and-different-version-number-formats.html#:~:text=Git,common%20way%20to%20denote%20versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so does it support both, and we are just standardizing on the one that we think is now "best practice"? or did something change about our release process such that it used to require no v
and now requires v
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It supports both, the composer does not break if we do not provide a 'v' prefix to our version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It supports both, the composer does not break if we do not provide a 'v' prefix to our version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it. thank you!
PR Description:
Issue
https://github.com/momentohq/dev-eco-issue-tracker/issues/719