Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update php sdk version #26

Merged
merged 3 commits into from
Mar 13, 2024
Merged

chore: update php sdk version #26

merged 3 commits into from
Mar 13, 2024

Conversation

rishtigupta
Copy link
Contributor

@rishtigupta rishtigupta commented Mar 12, 2024

PR Description:

  • Update PHP SDK Version to the latest "v.1.7.1"
  • Used a dockerfile to update the composer.lock to be in sync with composer.json

Issue

https://github.com/momentohq/dev-eco-issue-tracker/issues/719

Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still a draft or is it ready for review

@rishtigupta rishtigupta marked this pull request as ready for review March 13, 2024 22:50
@rishtigupta rishtigupta requested a review from cprice404 March 13, 2024 22:50
@@ -22,7 +22,7 @@
"source": "https://github.com/momentohq/laravel-cache"
},
"require": {
"momentohq/client-sdk-php": "1.3.0"
"momentohq/client-sdk-php": "v1.7.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've been confused as to why these dep versions are switching between not having a v prefix and having a v prefix. do you know why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so does it support both, and we are just standardizing on the one that we think is now "best practice"? or did something change about our release process such that it used to require no v and now requires v?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It supports both, the composer does not break if we do not provide a 'v' prefix to our version number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It supports both, the composer does not break if we do not provide a 'v' prefix to our version number.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. thank you!

@rishtigupta rishtigupta requested a review from cprice404 March 13, 2024 23:04
@rishtigupta rishtigupta merged commit 76bd65d into main Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants