Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api gateway metrics #323

Merged
merged 3 commits into from
May 29, 2024
Merged

feat: add api gateway metrics #323

merged 3 commits into from
May 29, 2024

Conversation

pgautier404
Copy link
Contributor

No description provided.

@pgautier404 pgautier404 force-pushed the add-apig-metrics branch 2 times, most recently from 65e8ed7 to 7e4e748 Compare May 20, 2024 20:37
@pgautier404 pgautier404 marked this pull request as ready for review May 21, 2024 16:54
@pgautier404 pgautier404 marked this pull request as draft May 22, 2024 20:20
@pgautier404 pgautier404 force-pushed the add-s3-metrics branch 6 times, most recently from 0aabfc8 to a5052e9 Compare May 22, 2024 22:00
@pgautier404 pgautier404 force-pushed the add-apig-metrics branch 3 times, most recently from 8661711 to 19a5bb4 Compare May 22, 2024 22:22
@pgautier404 pgautier404 marked this pull request as ready for review May 22, 2024 22:23
Base automatically changed from add-s3-metrics to main May 29, 2024 18:08
let list_apis_bar = ProgressBar::new_spinner().with_message("Listing API Gateway resources");
list_apis_bar.enable_steady_tick(std::time::Duration::from_millis(100));

let resp = apig_client.get_rest_apis().send().await?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to paginate on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added pagination and rate limiting.

Copy link
Contributor

@bruuuuuuuce bruuuuuuuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pgautier404 pgautier404 merged commit c5a2376 into main May 29, 2024
3 checks passed
@pgautier404 pgautier404 deleted the add-apig-metrics branch May 29, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants