chore: improve progress bars in cloud-linter #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the metrics calls from the describe tables calls for elasticache and serverless elasticache. This lets us use a spinner for the describe calls, and then a standard progress bar for the metrics calls. Remove an extra call to increment the s3 progress bar. Add a progress bar to display that we are writing out the results file. Misc linter fixes.
cprice404
reviewed
Jun 5, 2024
| @@ -258,7 +258,6 @@ async fn process_buckets( | |||
| let region_clone = region.to_string().clone(); | |||
| let progress_bar_clone = process_buckets_bar.clone(); | |||
| let spawn = tokio::spawn(async move { | |||
| progress_bar_clone.inc(1); | |||
cprice404
previously approved these changes
Jun 5, 2024
bruuuuuuuce
reviewed
Jun 5, 2024
Break the ElastiCache resources into chunks to append metrics and send them to the output writer.
bruuuuuuuce
reviewed
Jun 6, 2024
| .append_metrics(metrics_client, Arc::clone(&metrics_limiter)) | ||
| .await?; | ||
| while !resources.is_empty() { | ||
| let chunk: Vec<ServerlessElastiCacheResource> = resources |
There was a problem hiding this comment.
i like this way better than how I was doing this :fistbump:. Not for this pr, but would be nice to have a higher level function around this, to just DRY up the code around this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the metrics calls from the describe tables calls for elasticache and serverless elasticache. This lets us use a spinner for the describe calls, and then a standard progress bar for the metrics calls.
Remove an extra call to increment the s3 progress bar.
Add a progress bar to display that we are writing out the results file.
Misc linter fixes.