Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement HSET #15

Merged
merged 6 commits into from
Jul 3, 2024
Merged

feat: implement HSET #15

merged 6 commits into from
Jul 3, 2024

Conversation

anitarua
Copy link
Collaborator

@anitarua anitarua commented Jul 1, 2024

Work towards https://github.com/momentohq/dev-eco-issue-tracker/issues/927

Overall, took about half a work day to get to the point of cutting the first PR.
Extra time was spent resolving some github CI secrets issue but that should be a onetime thing.

Will cut another PR to do some minor polishing up (readme/contributing templates and gh actions workflows, switch auth token to api key, etc).

@anitarua anitarua marked this pull request as ready for review July 2, 2024 17:57
Copy link

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me, just a few comments!

momento-redis/hash_commands.go Outdated Show resolved Hide resolved
momento-redis/hash_commands_test.go Show resolved Hide resolved
@anitarua anitarua requested a review from cprice404 July 3, 2024 18:09
Copy link

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@anitarua anitarua merged commit 8d8bf05 into main Jul 3, 2024
2 checks passed
@anitarua anitarua deleted the hset branch July 3, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants