Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update readmes #16

Merged
merged 10 commits into from
Jul 3, 2024
Merged

chore: update readmes #16

merged 10 commits into from
Jul 3, 2024

Conversation

anitarua
Copy link
Collaborator

@anitarua anitarua commented Jul 2, 2024 •
edited
Loading

Some minor polishing up of the repo.

  • Added generation and verification workflows for README and CONTRIBUTING
  • Switched verbiage from "auth token" to "api key"
  • Added HSET to the API support table in the README

@anitarua anitarua changed the title chore: switch MOMENTO_AUTH_TOKEN to MOMENTO_API_KEY chore: switch MOMENTO_AUTH_TOKEN to MOMENTO_API_KEY, add readme generation workflows Jul 2, 2024
@anitarua anitarua changed the title chore: switch MOMENTO_AUTH_TOKEN to MOMENTO_API_KEY, add readme generation workflows chore: update readmes Jul 2, 2024
@anitarua anitarua marked this pull request as ready for review July 2, 2024 19:43
cprice404
cprice404 reviewed Jul 3, 2024
View reviewed changes
Copy link

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wonderful, thanks a bunch for doing it!!

just left one minor suggestion.

README.template.md Outdated Show resolved Hide resolved
@anitarua anitarua requested a review from cprice404 July 3, 2024 17:19
cprice404
cprice404 approved these changes Jul 3, 2024
View reviewed changes
Copy link

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@anitarua anitarua merged commit 7d0e31e into main Jul 3, 2024
3 checks passed
@anitarua anitarua deleted the update-readme branch July 3, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cprice404 cprice404 cprice404 approved these changes

@pgautier404 pgautier404 Awaiting requested review from pgautier404

@bruuuuuuuce bruuuuuuuce Awaiting requested review from bruuuuuuuce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anitarua @cprice404