Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunithm and other big patches #343

Merged
merged 14 commits into from
Feb 27, 2024
Merged

Chunithm and other big patches #343

merged 14 commits into from
Feb 27, 2024

Conversation

Yonokid
Copy link
Contributor

@Yonokid Yonokid commented Feb 6, 2024

Changelog:
Chunithm "Plus" versions have been separated into their own pages to keep formatting the same; all versions have new images
Chunithm Sun and Sun Plus have been added
Jubeat Ave has been added
Old dancerush patches have been appended
Taiko's name has been slightly modified to reflect changes
Wacca Reverse has been added

@mon
Copy link
Owner

mon commented Feb 7, 2024

I cannot merge this with the changes to the images - most of them increased in size, with 0 visible change to the actual image (and 0 change to the actual dimensions, either).

I'll review the rest later

@Yonokid
Copy link
Contributor Author

Yonokid commented Feb 7, 2024

yeah sorry that it changed all of the images; I ran an imagemagick command in bulk assuming it would only modify ones that weren't 128x128 but it seemed to have made minor changes to all of them

@mon
Copy link
Owner

mon commented Feb 7, 2024

yeah sorry that it changed all of the images; I ran an imagemagick command in bulk assuming it would only modify ones that weren't 128x128 but it seemed to have made minor changes to all of them

Just to be clear I'm expecting a commit to fix this before I look at the rest

I hate mogrify now
@Yonokid
Copy link
Contributor Author

Yonokid commented Feb 7, 2024

nevermind, too many people have said they don't like the images regardless so im closing this request until I make better ones

@Yonokid Yonokid closed this Feb 7, 2024
@mon
Copy link
Owner

mon commented Feb 7, 2024

Damn seriously? And I literally just finished looking at the rest 😅

Well at any rate, once you satisfy people regarding the images, use spaces instead of tabs for indentation, it's screwy
image

The real solution here is for me to add auto-formatting as part of the PRs, but last time I checked github makes that really hard (API key permissions or something)

@Yonokid
Copy link
Contributor Author

Yonokid commented Feb 7, 2024

ah the curse of using notepad++ as an ide lol. I'll look through my files again then to make sure it shows up normally

@Yonokid
Copy link
Contributor Author

Yonokid commented Feb 8, 2024

ok now I am satisfied with my changes:
html files and images now have the same name and are categorized with their associated game
images are (generally speaking) standardized now
the site will switch to a dark theme if the user's browser/system preference is set to dark
deprecated patches have been marked with the danger tooltip
all tab indents have been changed to spaces
ported your "skip update check" patch from amazon to amazon plus
datecode versions have been added to games that had none
i do not remember the rest

@Yonokid Yonokid reopened this Feb 8, 2024
@mon
Copy link
Owner

mon commented Feb 8, 2024

I like the auto-darkmode, that's well overdue.

I cannot rename all the .html files as that breaks every single backlink on the internet (of which there are many to bemanipatcher). I would personally prefer games/<series>/<version>.html, but haven't bothered to fill in my local .htaccess file with 302s to solve the link rot.

Similarly with images, it might be worth folder-ising them, but I'm not gonna push for it (the change you've made already is great).

@mon
Copy link
Owner

mon commented Feb 8, 2024

If you do bother to put the images into folders, also make games with more than 10 mixes 2 digits - lexical sort strikes again
image

@Yonokid
Copy link
Contributor Author

Yonokid commented Feb 8, 2024

ok give me a couple minutes to revert the name changes on the html files

@Yonokid
Copy link
Contributor Author

Yonokid commented Feb 8, 2024

ok everything should be good now; ive also added the paradise lost image to chuni when the mouse hovers over the paradise image

@mon
Copy link
Owner

mon commented Feb 9, 2024

Some of these images are a bit screwy - why no more transparency? Why the huge decrease in sharpness?
image

Also img/chu/ni11paradiselost.png is still 256px

@Yonokid
Copy link
Contributor Author

Yonokid commented Feb 9, 2024

Not really sure what happened with the sharpness? I recreated those images from source so I exported them as 128x128 images. The reason I removed transparency is because there were only about 3 images that had it; when put altogether its really an all or nothing situation, it looks strange when only a handful have transparency and all of the others have a white background. Transparent background images are also much harder to see in the newly added dark mode

@mon
Copy link
Owner

mon commented Feb 26, 2024

Sorry for the big delay in re-reviewing after your changes, I'm currently dealing with a house move ._.

  • Multiple .html files have still been renamed, such as reflec, beatstream, and jubeat
  • wacca reverse still has references to jquery and filesaver

And for things that are fine:

  • ave is OK
  • I like that you've removed all the parentheses in chuni version names
  • I like the [DEPRECATED] added to some patches that (I assume) aren't needed in new segatools
  • chuni/nost sharpness has been resolved

I may create a little redirect for the renamed chusannewplus (since it got renamed too) for my webserver just so the links don't break. I'm kinda tempted to just commit the .htaccess file to the repo so it's super obvious that redirects aren't magic. Any thoughts?

@Yonokid
Copy link
Contributor Author

Yonokid commented Feb 26, 2024

Ok, I've pushed your changes. There's only two files that I'm very unwilling to change:

  1. chuninewplus.html -> chusannewplus.html (having SDHD versions labeled as chusan makes them much easier to find)
  2. resort_anthem.html -> resortanthem.html (this is the only file that used snake case and it was bothering me)

@mon
Copy link
Owner

mon commented Feb 27, 2024

Alright, I've added a .htaccess file. This PR is already huge, so if you want to utilise this to re-commit the cleaned up names, please make a new PR for it.

@mon mon merged commit 3b6055b into mon:master Feb 27, 2024
1 check passed
@Yonokid
Copy link
Contributor Author

Yonokid commented Feb 27, 2024

great thank you so much!!!!!

@Yonokid Yonokid deleted the variouspatches branch December 5, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants