-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunithm and other big patches #343
Conversation
mogrify -resize 128x128 *.png
I cannot merge this with the changes to the images - most of them increased in size, with 0 visible change to the actual image (and 0 change to the actual dimensions, either). I'll review the rest later |
yeah sorry that it changed all of the images; I ran an imagemagick command in bulk assuming it would only modify ones that weren't 128x128 but it seemed to have made minor changes to all of them |
Just to be clear I'm expecting a commit to fix this before I look at the rest |
I hate mogrify now
nevermind, too many people have said they don't like the images regardless so im closing this request until I make better ones |
ah the curse of using notepad++ as an ide lol. I'll look through my files again then to make sure it shows up normally |
ok now I am satisfied with my changes: |
I like the auto-darkmode, that's well overdue. I cannot rename all the .html files as that breaks every single backlink on the internet (of which there are many to bemanipatcher). I would personally prefer games/<series>/<version>.html, but haven't bothered to fill in my local .htaccess file with 302s to solve the link rot. Similarly with images, it might be worth folder-ising them, but I'm not gonna push for it (the change you've made already is great). |
ok give me a couple minutes to revert the name changes on the html files |
ok everything should be good now; ive also added the paradise lost image to chuni when the mouse hovers over the paradise image |
Not really sure what happened with the sharpness? I recreated those images from source so I exported them as 128x128 images. The reason I removed transparency is because there were only about 3 images that had it; when put altogether its really an all or nothing situation, it looks strange when only a handful have transparency and all of the others have a white background. Transparent background images are also much harder to see in the newly added dark mode |
Sorry for the big delay in re-reviewing after your changes, I'm currently dealing with a house move ._.
And for things that are fine:
I may create a little redirect for the renamed chusannewplus (since it got renamed too) for my webserver just so the links don't break. I'm kinda tempted to just commit the .htaccess file to the repo so it's super obvious that redirects aren't magic. Any thoughts? |
Ok, I've pushed your changes. There's only two files that I'm very unwilling to change:
|
Alright, I've added a |
great thank you so much!!!!! |
Changelog:
Chunithm "Plus" versions have been separated into their own pages to keep formatting the same; all versions have new images
Chunithm Sun and Sun Plus have been added
Jubeat Ave has been added
Old dancerush patches have been appended
Taiko's name has been slightly modified to reflect changes
Wacca Reverse has been added