Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synonym sync: Test mondo.sssom.tsv filtering #706

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Nov 21, 2024

Note

Overview

Tests to ensure that synonym sync is only adding cases where an (exact match) entry appears in mondo.sssom.tsv for the given Mondo/source term pair.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

  • Yes
  • No, updates to the docs were not necessary after careful consideration

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after
docker pull obolibrary/odkfull:dev), and no errors occurred?

  • Yes
  • No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

  • Yes

@joeflack4 joeflack4 marked this pull request as draft November 21, 2024 23:59
@joeflack4 joeflack4 self-assigned this Nov 21, 2024
@twhetzel
Copy link
Contributor

twhetzel commented Nov 26, 2024

@joeflack4 #695 was already merged, what need to happen here? Also, I updated the branch to merge into to develop.

@twhetzel twhetzel changed the base branch from main to develop November 26, 2024 23:23
@joeflack4
Copy link
Contributor Author

@twhetzel thanks, it looks like a couple branches were set to main.

This is a test to make sure it's doing what it's supposed to be doing. One of the tests is complete, and the other is almost complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants