Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor VBO definitions #209 #210

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Refactor VBO definitions #209 #210

merged 5 commits into from
Dec 11, 2024

Conversation

katiermullen
Copy link
Collaborator

Addresses #209

@katiermullen katiermullen marked this pull request as draft November 11, 2024 21:12
@katiermullen
Copy link
Collaborator Author

@sabrinatoro please review at your convenience and do not merge. Thank you!

@katiermullen
Copy link
Collaborator Author

@sabrinatoro please review updates:

  • Definitions of vertebrate breed and high level classifications.
  • Definitions of mixed breed dog and mixed breed cat

sabrinatoro
sabrinatoro previously approved these changes Nov 26, 2024
Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR. This can be merged after others have reviewed it.

Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do NOT apply my change suggestions, I made them only to explain what changes are needed (they are made to the wrong files!!!)

@katiermullen
Copy link
Collaborator Author

@sabrinatoro please review:

  • 'vertebrate breed' definition
  • high level classification definitions (e.g. 'dog breed')
  • 'breed reported in geographic location' relation
  • 'mixed breed cat' definition
  • 'mixed breed dog' definition

Thank you!!!

update dadis breed country due to QC fail
@katiermullen
Copy link
Collaborator Author

katiermullen commented Dec 10, 2024

@matentzn we have updated the definition of dog breed to "A breed of Canis lupis familiaris." Sabrina and I want to make sure that you think this is okay since we define "Vertebrate breed" and not "breed" in the ontology.

For convenience, "vertebrate breed" definition is:
A taxonomic entity representing a population of vertebrate animals that share specific characteristics (such as traits, behavior, genetics) and/or for which cultural or geographical separation has led to the general acceptance of its separate identity.

@matentzn
Copy link
Member

This is correct, using "vertebrate" in this context is redundant as the taxon is already vertebrate.

@katiermullen katiermullen marked this pull request as ready for review December 10, 2024 21:26
@katiermullen
Copy link
Collaborator Author

@sabrinatoro ready for your review!

@cmungall we have updated the definition of "dog breed" to "A breed of Canis lupis familiaris."

For convenience, "vertebrate breed" definition is: "A taxonomic entity representing a population of vertebrate animals that share specific characteristics (such as traits, behavior, genetics) and/or for which cultural or geographical separation has led to the general acceptance of its separate identity."

Please let us know if you have any comments, otherwise we will forge ahead!

Copy link
Collaborator

@sabrinatoro sabrinatoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katiermullen I approve this PR. Great job!
I think it is ready to merge, but in case there was one last thing, I will let you merge it yourself.
Truly great job!

@katiermullen katiermullen merged commit 5a77630 into master Dec 11, 2024
1 check passed
@katiermullen katiermullen deleted the issue-209 branch December 11, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants