-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor VBO definitions #209 #210
Conversation
Addresses #209
@sabrinatoro please review at your convenience and do not merge. Thank you! |
@sabrinatoro please review updates:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR. This can be merged after others have reviewed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do NOT apply my change suggestions, I made them only to explain what changes are needed (they are made to the wrong files!!!)
@sabrinatoro please review:
Thank you!!! |
@matentzn we have updated the definition of dog breed to "A breed of Canis lupis familiaris." Sabrina and I want to make sure that you think this is okay since we define "Vertebrate breed" and not "breed" in the ontology. For convenience, "vertebrate breed" definition is: |
This is correct, using "vertebrate" in this context is redundant as the taxon is already vertebrate. |
@sabrinatoro ready for your review! @cmungall we have updated the definition of "dog breed" to "A breed of Canis lupis familiaris." For convenience, "vertebrate breed" definition is: "A taxonomic entity representing a population of vertebrate animals that share specific characteristics (such as traits, behavior, genetics) and/or for which cultural or geographical separation has led to the general acceptance of its separate identity." Please let us know if you have any comments, otherwise we will forge ahead! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katiermullen I approve this PR. Great job!
I think it is ready to merge, but in case there was one last thing, I will let you merge it yourself.
Truly great job!
Addresses #209