Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tsemach/add commands for manifest management #110

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

tsemachLi
Copy link
Contributor

@tsemachLi tsemachLi commented Dec 23, 2024

Summary

Introduced two new beta commands for easier app management:

  • manifest:export: Export an app manifest by specifying the app ID and app version ID. The manifest ZIP file will be downloaded to your current working directory.
  • manifest:import: Import a manifest file by providing the file path. The file will be zipped and uploaded to either an existing app or a new app, as specified.

Purpose

These commands simplify app configuration management, enabling developers to easily export and import app setups for improved workflows and version control.

Notes

  • The commands are in beta;

Copy link
Contributor

@gregra81 gregra81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing 🚀
See my comments please

src/commands/manifest/export.ts Outdated Show resolved Hide resolved
src/commands/manifest/export.ts Outdated Show resolved Hide resolved
src/commands/manifest/import.ts Outdated Show resolved Hide resolved
src/commands/manifest/import.ts Show resolved Hide resolved
src/commands/manifest/import.ts Outdated Show resolved Hide resolved
src/services/import-manifest-service.ts Outdated Show resolved Hide resolved
src/services/import-manifest-service.ts Outdated Show resolved Hide resolved
src/services/import-manifest-service.ts Outdated Show resolved Hide resolved
src/services/import-manifest-service.ts Outdated Show resolved Hide resolved
return userChoice === CREATE_NEW_VERSION;
};

export const uploadZippedManifest = async (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question about zip VS normal file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manifest endpoints support only zip format (in oder to support in feature dependencies and assets such as images etc...)

@tsemachLi tsemachLi requested a review from gregra81 December 24, 2024 09:38
Copy link
Contributor

@gregra81 gregra81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants