Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remediation for sshd ClientAliveInterval #308

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix remediation for sshd ClientAliveInterval #308

merged 1 commit into from
Dec 20, 2023

Conversation

tomtrix
Copy link
Contributor

@tomtrix tomtrix commented Dec 20, 2023

Dear Mondoo team,

thanks for your aweseome work!

At a customer project I've discovered, that your remediation for ClientAliveInterval at the sshd configuration isn't valid. The Open SSH server requires an integer, not the given text. This PR fixes the issue.

This is my first Open Source contribution, so please tell me, if I could do something better. Thanks! :)

Looking forward to the merge and have nice holidays.

Kind regards,
Tom

for ClientAliveInterval
Copy link

github-actions bot commented Dec 20, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@tomtrix
Copy link
Contributor Author

tomtrix commented Dec 20, 2023

I have read the Mondoo CLA Document and I hereby sign the CLA

Copy link
Member

@atomic111 atomic111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomtrix thanks for the improvement

@atomic111 atomic111 merged commit df13c63 into mondoohq:main Dec 20, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants