✨ Use structured errors #439
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Zunker <[email protected]>
|
This uses the structured errors from mondoohq/cnquery#924. It is a follow-up to #424 |
czunker
commented
Mar 14, 2023
| if r.data.Errors[assetsByPlatform[platform][i].Mrn] != nil { | ||
| es := r.data.Errors[assetsByPlatform[platform][i].Mrn] | ||
| ei := errdetails.ErrorInfo{} | ||
| pberr := anypb.UnmarshalTo(es.Details[0], &ei, proto.UnmarshalOptions{}) |
There was a problem hiding this comment.
The explorer ErrorStatusCode is buried in the details, so I have to unpack it here.
czunker
commented
Mar 14, 2023
| if len(executionJob.Queries) == 0 { | ||
| // send a proto error with details, so that the agent can render it properly | ||
| msg := "resolved policy does not contain any queries" | ||
| st := status.New(codes.NotFound, msg) |
There was a problem hiding this comment.
When we could use the explorer.NoQueries code here, that would make other parts of the code easier.
I'm not sure whether I missed something here or it just isn't possible. I didn't manage to replace the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.