Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ add configuration to enable Linux/macOS service #317

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

atomic111
Copy link
Member

No description provided.

@atomic111 atomic111 changed the title add configuration to enable Linux/macOS service ⭐️ add configuration to enable Linux/macOS service Jul 16, 2023
@atomic111 atomic111 force-pushed the patrick/installer-service branch 2 times, most recently from e2f6616 to 45ab18f Compare July 20, 2023 08:05
install.sh Outdated Show resolved Hide resolved
install.sh Outdated
Comment on lines 56 to 57
echo " -s <service>: Enables the cnspec service for the system." >&2
echo " options are: enable" >&2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atomic111 is there an option for disable as well? if not, why do we have options? Why not just -s enables cnspec to run as a service?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to create the disable option later

Copy link
Contributor

@scottford-io scottford-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atomic111 a couple of suggestions for you.

atomic111 and others added 2 commits August 2, 2023 19:29
Co-authored-by: Scott Ford <[email protected]>
Signed-off-by: Patrick Münch <[email protected]>
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @atomic111

install.sh Show resolved Hide resolved
@atomic111 atomic111 merged commit fe3efa4 into main Aug 2, 2023
5 checks passed
@atomic111 atomic111 deleted the patrick/installer-service branch August 2, 2023 21:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants