Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker/build-push-action is no longer platform agnostic #467

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

benr
Copy link
Member

@benr benr commented Aug 8, 2024

2 months ago dependabot automatically updated the docker/build-push-action@v6 action from v5 to v6. After this change arm64 test builds failed because you need to explicitly define the build environment. We could create a conditional statement to select the right platform based on the input image, however we're only testing install-sh and there isn't real value in doing this in arm64 in particular, it's the OS variants we need to test. Therefore, rather than make the action unnecessarily complicated we'll just remove the arm64 build.

@benr benr self-assigned this Aug 8, 2024
@benr benr requested a review from chris-rock August 8, 2024 01:56
@benr benr merged commit 27a4cda into main Nov 5, 2024
8 checks passed
@benr benr deleted the benr/arm64-build-test branch November 5, 2024 03:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants