Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Enable Scan API also for node scanning #844

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Aug 21, 2023

The node GC depends on the Scan API. Because of that we also need to create the Scan API when only node scanning is active.

Fixes https://github.com/mondoohq/server/issues/6267

The node GC depends on the Scan API. Because of that we also need to create the Scan API when only node scanning is active.

Fixes mondoohq/server#6267

Signed-off-by: Christian Zunker <[email protected]>
Signed-off-by: Christian Zunker <[email protected]>
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @czunker

@@ -405,10 +405,13 @@ prep/tools/ranger:

prep/repos:
test -x cnquery || git clone https://github.com/mondoohq/cnquery.git
# workaround for now. Needs to be removed as we move to v9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: whitespace

test -x cnspec || git clone https://github.com/mondoohq/cnspec.git

prep/repos/update: prep/repos
cd cnquery; git checkout main && git pull; cd -;
# workaround for now. Needs to be removed as we move to v9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: whitespace

@czunker czunker merged commit 0c1d20d into main Aug 21, 2023
@czunker czunker deleted the christian/fix_node_gc branch August 21, 2023 08:08
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants