RouterInfo: refactor buffer getter

- Removes unnecessary buffer loading function
- Refactors getter to load buffer if empty

src/core/router/info.cc

@@ -613,7 +613,7 @@ void RouterInfo::Update(const std::uint8_t* buf, std::uint16_t len)
   // don't delete buffer until saved to file
 }
 
-const std::uint8_t* RouterInfo::LoadBuffer()
+const std::uint8_t* RouterInfo::GetBuffer() const
 {
   if (!m_Buffer)
     {

src/core/router/info.h

@@ -462,11 +462,6 @@ class RouterInfo : public RouterInfoTraits, public RoutingDestination
   /// @param len New RI length
   void Update(const std::uint8_t* buf, std::uint16_t len);
 
-  /// @brief Loads RI buffer (by reading) if buffer is not yet available
-  /// @notes Required by NetDb
-  /// TODO(anonimal): remove, refactor (buffer should at least be guaranteed with getter)
-  const std::uint8_t* LoadBuffer();
-
   /// @brief Create RI and put into buffer
   /// @param private_keys Private keys used to derive signing key
   ///   (and subsequently sign the RI with)
@@ -491,12 +486,8 @@ class RouterInfo : public RouterInfoTraits, public RoutingDestination
 
  public:
   /// @return Pointer to RI buffer
-  /// TODO(anonimal): refactor
-  const std::uint8_t* GetBuffer() const
-  {
-    auto buf = m_Buffer.get();
-    return buf;
-  }
+  /// @notes Loads RI from file if buffer is not yet available
+  const std::uint8_t* GetBuffer() const;
 
   /// @return RI buffer length
   std::uint16_t GetBufferLen() const noexcept

src/core/router/net_db/impl.cc

@@ -725,7 +725,6 @@ void NetDb::HandleDatabaseLookupMsg(
       auto router = FindRouter(ident);
       if (router) {
         LOG(debug) << "NetDb: requested RouterInfo " << key.data() << " found";
-        router->LoadBuffer();
         if (router->GetBuffer())
           reply_msg = CreateDatabaseStoreMsg(router);
       }