This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
RouterInfo: various refactoring #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related refactoring + access with scope operator for clarity (enums are still unscoped)
And related refactoring.
'Tis redundant/confusing.
'Tis redundant.
Now accessible as RI trait.
- Pulls getters out of nested classes and into enclosed class - Implements RI traits in place of hard-coded strings * also added cost + date RI trait - Logs a definitive delimiter + terminator which allows for more accurate/easier regexp when searching through logs - Removes excessive std::endl (we don't need to flush for every newline) - Now returns const type
anonimal
commented
Apr 14, 2017
| /// @brief Human readable description of this struct | ||
| /// @param prefix for tabulations | ||
| /// @returns human readable string | ||
| std::string GetDescription(const std::string& tabs = std::string()) const; |
There was a problem hiding this comment.
@MoroccanMalinois FYI, OOP-wise, I preferred your approach but, considering the use-case, the extra hoops we'd have to jump through to implement nested scope access to enclosed members would probably not have been in our best interest.
There was a problem hiding this comment.
@anonimal i totally agree :)
anonimal
added a commit
that referenced
this pull request
Apr 17, 2017
39c0223 UPnP: update member/trait names from RI refactor (anonimal) fea491d RouterInfo: refactor description getter (anonimal) 5bfdf3f RouterInfo: capabilities flag refactor (anonimal) e09907c RouterInfo: rename member for Address' address (anonimal) 2445189 RouterInfo: rename transport member in Address class (anonimal) 65c52f5 RouterInfo: type refactor for Address/Introducer port (anonimal) f06ae44 RouterInfo: initialize Introducer class integer members (anonimal) 6a0921d RouterInfo: enum refactor + document (anonimal)
This was referenced Apr 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Live tests pass. Referencing #617. This WIP is in pursuit of isolating #187.
Note for any reviewers: if skimming through the GitHub "Files Changed" tab, a clickable "Large diffs are not loaded by default" for
router/info.ccis tucked into the diff.Edit: referencing #627
By submitting this pull-request, I confirm the following: