This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
RouterInfo: fixes + refactoring #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Option", not "property".
Replaces base64 conversion with ident hash's built-in member function.
Now operates directly on object through return reference getter.
- RI *has* said traits, not *is* said traits - Clarify compatibility functions - Does not effect bool member setters/getters
and related refactoring
- Removes copypasta code - Removes redundent checks - Adds important notes/TODO's - Adds debug logging
- Implements function for bitwise verification - Refactor bool logic
- Use bitwise operations to ensure appropriate transport and version - Refactor bool logic + remove unnecessary code - Implement transport trait getter + add debug logging - Related refactoring + add docs
anonimal
added a commit
that referenced
this pull request
Apr 29, 2017
378e11d RouterInfo: refactor address getters + their logic (anonimal) 7f56f7b RouterInfo: refactor Has* transport verifiers (anonimal) 9c75699 RouterInfo: GetDescription: supply host trait, not cost (anonimal) 75831fb RouterInfo: fix IP version when adding NTCP address (anonimal) 6d0f8af RouterInfo: refactor V6 enabler/disabler + add docs (anonimal) 0ab5044 RouterInfo: inline Has* getters + setter (anonimal) 53f9410 RouterInfo: replace trait Is* functions with Has* (anonimal) 74d63a0 RouterInfo: remove unnecessary functions for options (anonimal) 4faefb2 RouterInfo: remove unnecessary Base64 function (anonimal) 1dfd108 RouterInfo: refactor public caps setter / flags getter (anonimal) 9111ae6 RouterInfo: align language with RI specification (anonimal) 4293427 RouterInfo: remove dead code in header (anonimal)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Lives tests pass with v6 enabled/disabled. Referencing #627.
By submitting this pull-request, I confirm the following: