This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
RouterInfo: fixes + additions + refactoring #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initialize members in declaration - Throw ctor if null RI buffer - Fix buffer length check - Remove unneeded load code - Related refactoring + add docs
- Related refactoring
- Related refactoring * Cast cost as unsigned type
anonimal
changed the title
- Throws on invalid buffer length - Refactor minimum buffer size as DSA sig length for clarity
anonimal
added a commit
that referenced
this pull request
May 3, 2017
dc79308 RouterInfo: mitigate underflow when creating/updating buffer (anonimal) 4a80001 RouterInfo: throw if ident length from buffer is null (anonimal) d6d63fa RouterInfo: use sizeof intro key when creating bytestream (anonimal) 05141f8 RouterInfo: add error handling for bad introducer host (anonimal) f15e076 RouterInfo: add more members to description getter (anonimal) 8c73e92 RouterInfo: use unsigned type for member buf length (anonimal) 1e154e5 RouterInfo: add RI length check when creating buffer (anonimal) 6413e85 RouterInfo: move cost raw values to enum (anonimal) 8e33444 RouterInfo: refactor / fix ctor's (anonimal) 2a40b3d RouterInfo: refactor RI file saver (anonimal) 5d746ea RouterInfo: refactor RI file loader (anonimal) b5366cf RouterInfo: refactor size constants (anonimal)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Referencing #627.
By submitting this pull-request, I confirm the following: