Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatpak: Change the branch to stable #4231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

flatpak: Change the branch to stable #4231

wants to merge 1 commit into from
+102 −76

Conversation

BigmenPixel0
Copy link
Contributor

@BigmenPixel0 BigmenPixel0 commented Oct 21, 2023 •
edited
Loading

It can be pushed after Monero gets verified on Flathub and the stable token is added to the FLATHUB_TOKEN environment. Also, we need to wait for this.

@BigmenPixel0 BigmenPixel0 mentioned this pull request Oct 21, 2023
Open
@plowsof
Copy link
Contributor

plowsof commented Oct 21, 2023

github secret variable names:
current beta token : FLATHUB_
proposed stable token name in this PR: FLATHUB_TOKEN

which barth will pgp encrypt for luigi (just as was done for the beta api key)

@selsta
Copy link
Collaborator

selsta commented Oct 21, 2023

Did you test all these changes and made sure everything still builds successfully?

@BigmenPixel0
Copy link
Contributor Author

Did you test all these changes and made sure everything still builds successfully?

Not all, because it's very long to wait, but all detected problems/errors will be solved when this pr becomes not-draft.

@BigmenPixel0
Copy link
Contributor Author

BTW, this was needed to build, I right now detected this was pushed.

@BigmenPixel0 BigmenPixel0 force-pushed the switch-to-stable branch 4 times, most recently from da8f0d9 to b408729 Compare April 3, 2024 14:26
@BigmenPixel0 BigmenPixel0 marked this pull request as ready for review April 3, 2024 14:35
@adrelanos
Copy link

I don't understand too much about this process but it seems to me that to make progress towards

it is required to merge this pull request first. This is based on the following. Quote flathub/flathub#3905 (comment)

me:

Is barthalion even still active?

Consider opening an issue at https://github.com/flathub/flathub to ask about this so maybe someone else from Flathub can reply and not waiting forever for a person that is no longer responsive?

barthalion (avoiding potentially unnecessary ping by avoding to use @):

Yes, I am. Maybe try to look around before producing another notification cluttering my inbox?

Unless the app gets verified and monero-project/monero-gui#4231 is merged, I don't think there's much to talk about right now.

Therefore my question: Can this pull request be merged?

@BigmenPixel0
Copy link
Contributor Author

Therefore my question: Can this pull request be merged?

I need to update some dependencies and test it, then yes

@BigmenPixel0
Copy link
Contributor Author

I don't know what happened to the github runners but now it needs more time for aarch64. I think it's better to wait for the native aarch64 runners.

@plowsof
Copy link
Contributor

plowsof commented Aug 30, 2024

have the new native runners changed anything for build times? @BigmenPixel0

@BigmenPixel0
Copy link
Contributor Author

@plowsof they are available for Github customers on paid plans, so I don't know yet but it must because qemu is much slower anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BigmenPixel0 @plowsof @selsta @adrelanos