Fix indices used to check CLI and GUI file names in workflow #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for barolo-time-757cf9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nahuhh
reviewed
Mar 10, 2024
.github/workflows/hashes.yaml
Outdated
| #CLI | ||
| filename=$(get_filename "${line}") | ||
| filenames_cli+=("${filename}") | ||
| elif [ $num -gt 13 ] && [ $num -lt 20 ] ; then | ||
| elif [ $num -gt 14 ] && [ $num -lt 20 ] ; then |
There was a problem hiding this comment.
Suggested change
| elif [ $num -gt 14 ] && [ $num -lt 20 ] ; then | |
| elif [ $num -gt 14 ] && [ $num -lt 21 ] ; then |
is this right? 🤔
ignore me if wrong
There was a problem hiding this comment.
This was done in previous PR here: https://github.com/monero-project/monero-site/pull/2264/files#diff-e9682b56d580e2645c06a1fdde3c0376d1bee1e1a1cca99a900dbc7f7d902c12L61
Sorry I messed up my history and created an unnecessary conflict. Should be more clear now, please check.
binaryFate
force-pushed
the
workflow-fix-indices-for-file-names
branch
from
6336c9c to
0a47adb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current workflow failed on checking the last CLI file name.
Index between CLI and GUI (14-15) needs to be increased by 1 to accommodate new riscv64 file.