contributing: add view key + primary address #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HardenedSteel
force-pushed
the
view-keys
branch
2 times, most recently
from
19dfc76
to
2b49c38
Compare
✅ Deploy Preview for barolo-time-757cf9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
plowsof
approved these changes
Oct 16, 2024
|
LGTM just need several approvals as we're editing the donation address here. perhaps people have an opinion on how to display the keys. |
|
you made a great point about people seeing "primary address" and donating to that instead, which is fine but may confuse people with a view only wallet. Hiding them behind 1 summary that has the text "> View-only wallet" could be better |
Seconded |
HardenedSteel
force-pushed
the
view-keys
branch
from
2b49c38
to
9216a57
Compare
HardenedSteel
force-pushed
the
view-keys
branch
from
9216a57
to
b56a180
Compare
plowsof
approved these changes
Oct 18, 2024
selsta
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2071