Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update website tech, Astro soon #2405

Closed
wants to merge 1 commit into from

Conversation

jermanuts
Copy link
Contributor

Soon! Merge when live website is rebuilt in Astro.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 54fe7d5
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/67211d65cf363a000830ca8d
😎 Deploy Preview https://deploy-preview-2405--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nahuhh
Copy link
Contributor

nahuhh commented Oct 30, 2024

NACK

tl strings change with astro

edit: if opening a PR not meant for merge/review, open it as a draft

@plowsof
Copy link
Collaborator

plowsof commented Oct 30, 2024

re-open after astro conversion is done. i might even NACK this based on the commit history leading to confusion of who made the conversion.

@jermanuts jermanuts marked this pull request as draft October 31, 2024 07:54
@jermanuts
Copy link
Contributor Author

I made it a draft, won't probably cause a confusion as the PR for Astro conversion will be probably called something like "convert website to Astro"

@plowsof
Copy link
Collaborator

plowsof commented Oct 31, 2024

The structure of files (especially translation) is going to change.

It's possible there wont even be file named _i18n/en.yml. keeping this PR open, even as a draft, and showing any approval could cause the team working on the new astro site emotional distress thinking they are required to create a merge request that blends into current master branch.

Add your changes to the astro site / branch where development is taking place. not here.

There may also be an onus on the current site maintainer to adapt all PR's made to the "future astro" site and handle merge conflicts. For this particular PR it would all be because of a 1 word patch.

@jermanuts jermanuts closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants