Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove vim from musl docker file build #70

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 7, 2025

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

We don't need vim on every install of our alpine package, only when we're debugging inside the container

Double check the following

  • Ran npm run format:js && npm run format:rs script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson merged commit 275ef82 into main Feb 10, 2025
33 of 37 checks passed
@baileympearson baileympearson deleted the chore-rm-vim branch February 10, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants