DOCSP-43071: Bulk operations #54
Merged
+459
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
norareidy
commented
Sep 27, 2024
Comment on lines
+281
to
+282
| - :ref:`c-write-delete` | ||
| - :ref:`c-write-replace` |
stephmarie17
approved these changes
Sep 27, 2024
source/write/bulk-write.txt
Outdated
Comment on lines
51
to
52
| - Collection: Specifies the collection to modify | ||
| - Options document: Specifies options to customize the operation, or ``NULL`` |
There was a problem hiding this comment.
Suggested change
| - Collection: Specifies the collection to modify | |
| - Options document: Specifies options to customize the operation, or ``NULL`` | |
| - **Collection**: Specifies the collection to modify | |
| - **Options document**: Specifies options to customize the operation, or ``NULL`` |
source/write/bulk-write.txt
Outdated
| To run each write operation queued in the bulk write, call the ``mongoc_bulk_operation_execute()`` | ||
| function. This function accepts the following parameters: | ||
|
|
||
| - ``mongoc_bulk_operation_t`` value: Contains the instructions for each write operation |
There was a problem hiding this comment.
[s] Can also bold these terms per the style guide
source/write/update.txt
Outdated
| @@ -57,6 +57,8 @@ Each update function accepts the following parameters: | |||
| and their usage, see the :manual:`Field Update Operators guide | |||
| </reference/operator/update-field/>` in the {+mdb-server+} manual. | |||
|
|
|||
| - Options document: Specifies options to customize the operation, or ``NULL``. | |||
There was a problem hiding this comment.
[s] This list isn't fully from the diff, but I think the guidance around bolding terms would apply her as well.
kevinAlbs
reviewed
Sep 30, 2024
source/includes/write/bulk-write.c
Outdated
| "restaurant_id", BCON_UTF8 ("1234") | ||
| ); | ||
|
|
||
| mongoc_bulk_operation_insert_with_opts (bulk, insert_doc, NULL); |
There was a problem hiding this comment.
Add an out-parameter for a bson_error_t. Suggest checking the return:
bson_error_t error;
if (!mongoc_bulk_operation_insert_with_opts (bulk, insert_doc, NULL, &error)) {
fprintf (stderr, "error adding insert operation: %s\n", error.message);
}Suggestion also applies to other mongoc_bulk_operation_*_with_opts calls.
kevinAlbs
approved these changes
Oct 1, 2024
source/write/bulk-write.txt
Outdated
Comment on lines
212
to
213
| If any of the write operations fail, the {+driver-short+} raises a | ||
| ``mongoc_bulkwriteexception_t`` error and does not perform any further operations. |
There was a problem hiding this comment.
Remove mention of mongoc_bulkwriteexception_t. mongoc_bulkwriteexception_t applies to the mongoc_bulkwrite_t. mongoc_bulkwrite_t requires server 8.0. mongoc_bulk_operation_t can be used with any supported server version.
Suggested change
| If any of the write operations fail, the {+driver-short+} raises a | |
| ``mongoc_bulkwriteexception_t`` error and does not perform any further operations. | |
| If any of the write operations fail, the {+driver-short+} sets the output error and does not perform any further operations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43071
Staging - https://deploy-preview-54--docs-c.netlify.app/write/bulk-write/
Self-Review Checklist